This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Fix: log string deduplication - #2097
Merged
Merged
Conversation
dragonmux
previously approved these changes
Mar 21, 2025
ALTracer
force-pushed
the
fix/dedupe-strings
branch
from
July 21, 2025 10:16
c3ed8fc to
946a52e
Compare
* This enables linker relaxation across otherwise identical error strings
ALTracer
force-pushed
the
fix/dedupe-strings
branch
from
July 21, 2025 20:13
946a52e to
1b32838
Compare
…to a reflection array
ALTracer
force-pushed
the
fix/dedupe-strings
branch
from
July 21, 2025 20:32
0b01dc3 to
d3fee6f
Compare
Contributor
Author
|
Rebased. Added |
dragonmux
approved these changes
Jul 21, 2025
dragonmux
left a comment
Member
There was a problem hiding this comment.
Thank you for fixing that small oops that was identified in Discord, and rebasing this! Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
Discovered by staring at
strings -n16 build-f411ce/blackmagic_blackpill_f411ce_firmware.bin | lessoutput.DEBUG_TARGET()is enabled.stm32h7.c, I drop the logline I added previously for H7B3 compat FLASH_CR patcher helper, because the driver is tested to work and that logline spams output during flashing. -116 bytes.I would need some autobuilder script to measure size savings from each commit, but they're on the order of 50-100 bytes, for a total of about -292 bytes up to DEBUG_WARN, and -372 bytes more up to DEBUG_TARGET (-664).
Can't test on most of targets modified in PR scope. Idea similar to #1527 and #1863. Should have no effect on release firmware with disabled logging. When
-Ddebug_output=true, defaultnativeandswlink/stlink/bluepillandf072builds still overflow by 17-23 KiB. The other probe platforms are not 128 KiB but 256 KiB or even larger.Your checklist for this pull request
Closing issues